Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are 20 marmot repositories #1

Open
dsfaccini opened this issue Sep 9, 2022 · 9 comments
Open

There are 20 marmot repositories #1

dsfaccini opened this issue Sep 9, 2022 · 9 comments

Comments

@dsfaccini
Copy link

Including one by google
Maybe it'd be a good idea to change the name
Cool project though

@maxpert
Copy link
Owner

maxpert commented Sep 9, 2022

Interesting I didn't know Google had one too. I am open to name suggestions. It's early days so I think I can change the name easily. The reason I named it marmot to begin with was from the idea of nodes just shouting and getting change replicated. Initially the whole thing was over UDP (I was using QUIC) but later I converged to using Raft and TCP.

@x448
Copy link

x448 commented Sep 11, 2022

Finding an unused name is getting harder every day.

Somewhat related because this affects module name... In go.mod, the module name should include full prefix like this.

module github.com/maxpert/marmot

Otherwise, it won't get picked up by https://pkg.go.dev.

@maxpert
Copy link
Owner

maxpert commented Sep 11, 2022

Just did it, next version should have that as well. Changes are already on master.

@x448
Copy link

x448 commented Sep 11, 2022

Nice. You may need to tag a new release (not marked as pre-release). Then you can click submit without getting the error about module name at:

https://pkg.go.dev/github.com/maxpert/marmot

It seems to ignore releases marked as pre-release.

@maxpert
Copy link
Owner

maxpert commented Sep 11, 2022

Yep there should be a build out in a while with new disk based state-machine and early version of snapshot restoration as well. I still need someone to help me test it on something other than my deployment.

@maxpert
Copy link
Owner

maxpert commented Sep 12, 2022

It seems to ignore releases marked as pre-release.

Now I am getting

"github.com/maxpert/marmot" does not have a valid module path ("marmot").

@x448
Copy link

x448 commented Sep 12, 2022

If 0.3.9 was marked pre-release then maybe (just a wild guess) pkg.go.dev will continue ignoring it after it is unmarked.

You might need new release tag with new version number which wasn't used before. Just to be sure, make a small change to the README or some other file so the new version isn't on the same commit as 0.3.9.

@maxpert
Copy link
Owner

maxpert commented Sep 12, 2022

Done I was able to get it done. I feel like some community gathering around this. May be a discord or gitter channel will help.

@disarticulate
Copy link

marmolite might combine the

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants