-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webtty on web example does not work? #5
Comments
Can you paste your offer message? |
Actually, if you could email it to me. Email addr is on my github profile. |
I will send you one, but really any offer triggers the same problem (it already breaks as soon as I start typing). |
Ping |
I'm having this issue. I have the same error in Firefox and in chrome the error I have is:
This error occurs on key any press - I don't even think it recognizes the entire offer I paste in :/ |
UPDATE: I looked into the source the issue appears to be a missing Furthemore, to get it connect to a session you need to put your offer in the url as a hash argument - e.g: http://localhost:8080/#connection_data I'm not sure whether the |
The url hash was intended as a convenience, it shouldn't be required. |
The encode and decode functions are defined within webassembly. They are here: https://github.com/maxmcd/webtty/blob/master/web-client/src/main.go#L60-L63 If there was an error loading the webassembly those functions would not be available, but assuming success decode and encode should be available on the Appreciate you looking into this, I still haven't been able to reproduce on my end, will look into it again. |
Thanks for the quick reply! This is my system information, hopefully it helps:
Running
Any clues would be much appreciated, |
Hmmmm... I also run fedora, one system was fc28 the other fc29. Will try to test again soon. |
Hey @arjenpdevries, |
This seems to imply to me that WebTTY is just unusable for some/all users? I can't get an example working and I don't know how to resolve it at all. |
@rivertam maybe! I can get it working, this issue seems to (weirdly) be limited to Fedora. What kind of issue are you experiencing? (Feel free to open another issue or email me 😃 ) |
I'm actually experiencing this on Ubuntu with the exact same issues as above. I didn't look into this properly when I commented -- I'll see if there are errors in the console tomorrow. |
Given the report with Ubuntu above, it does not seem related to the linux distribution: |
Hey guys, mind checking this out with the new release? |
If I right-click and paste, instead of trying a ctrl-v in the window, the demo works. Suspect it's just the web client that's having this problem due to changes there. edit: oops, just saw the fix above. my bad. |
In both firefox and chrome, I get an error at https://maxmcd.github.io/webtty/, whenever I try to paste the offer message...
The text was updated successfully, but these errors were encountered: