Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immutable issue #165

Open
DzmitryBiruk opened this issue Nov 6, 2019 · 6 comments
Open

Immutable issue #165

DzmitryBiruk opened this issue Nov 6, 2019 · 6 comments

Comments

@DzmitryBiruk
Copy link

Hi looks like something is broken with immutable after latest update.

Screen Shot 2019-11-06 at 5 51 09 PM

@salvoravida
Copy link
Contributor

yeah

i suggest to export a reducer-immutable factory

export function createReducerImmutable(Immutable);

so there is NO require("immutable");

@maxmantz
Copy link
Owner

maxmantz commented Nov 6, 2019

@salvoravida great idea, will fix this ASAP.

Since this is an API change, semver dictates the next release to be version 4 instead of 3.1.7.
However, I will release a version 3.1.7 which will undo the previous change and then update to version 4.

@maxmantz maxmantz closed this as completed Nov 6, 2019
@maxmantz maxmantz reopened this Nov 6, 2019
@maxmantz
Copy link
Owner

Published changes to v4.0.0-beta1. Please check if this resolves your issues.

@salvoravida
Copy link
Contributor

yeah all ok!

@mwasplund
Copy link

I am still getting typescript compile errors when not using immutable:
node_modules/redux-oidc/index.d.ts:3:31 - error TS2307: Cannot find module 'immutable'.

3 import { Map, fromJS } from "immutable";

Can the immutable version be broken out into a separate file or package entirely?

@kamiljozwik
Copy link

kamiljozwik commented Sep 24, 2020

This bug is still present. Immutable is removed from dependencies, but imported in declaration file, which produces this problem.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants