Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can a new minor release be tagged soon? #688

Open
makinbacon21 opened this issue Mar 6, 2024 · 5 comments
Open

Can a new minor release be tagged soon? #688

makinbacon21 opened this issue Mar 6, 2024 · 5 comments

Comments

@makinbacon21
Copy link
Contributor

Would be nice to take advantage of new postorius and some of the fixes etc added since oct.

@almereyda
Copy link

I believe it would be best to parametrise and automate image builds in CI (here), in so new releases and builds become more easy.

@thomas955
Copy link

It would be nice to have a new release soon as the libldap library is still missing.

2331cb3 was already merged but is not yet in the latest tag.

Thank you in advance.

@almereyda
Copy link

This is also mildly concerning, as it is one of the publicly announced installation methods.

It used to be the only installation method in the beginning, why many installations may depend on this setup to be supported already.

In case the project has fallen out of support, it could be good to coordinate here about putting the repository into shared maintainership at an independent GitHub organisation, or with upstream about a soft-fork, say continuation, of the repository and adopting it into gitlab.com/mailman/.

The forks could be synced, in so the old image names and CI setups for image builds can be continued to be used.

@maxking
Copy link
Owner

maxking commented Jun 5, 2024

I haven't had a chance to fix the CI yet, which is broken for some reason and need to take a look at it. If someone can help debug and propose required changes for the CI to pass, I can maybe cut a release this weekend.

I believe it would be best to parametrise and automate image builds in CI (here), in so new releases and builds become more easy.

It mostly is automated, there is not much to do except make a release with a tag.

say continuation, of the repository and adopting it into gitlab.com/mailman/.

I don't expect rest of the Mailman developers to worry about packaging as well. I don't know if "first" in the list really has a lot of insinuation but that definitely wasn't the intent. Mailman developers really only support virtualenv style install, for anything else, you want to the packaging team's help.

@almereyda
Copy link

Can you give some detail on what is currently broken and how the images are usually being built?

I hadn't seen a previous issue about missing builds, but now that you mention it and given the previous failed runs, it appears this is broken for many months now?

Can be good for everyone to find an issue in the future, in case they are not aware themselves, so the community can look at it together.

Am I correct in assuming, that we are talking about the cron-builds pipelines in CircleCI?

From looking at the logs of the last job, it seems there is an issue with not being able to import utc.

ImportError: cannot import name 'utc' from 'django.utils.timezone' (/usr/lib/python3.11/site-packages/django/utils/timezone.py)

Maybe it's really just a packaging or rather an upstream issue?

It's these two lines in HyperKitty:

This may have broken with upgrading to Django 5, where utc is depreciated.

From the Django 5.0 release notes | Django documentation | Django:

The django.utils.timezone.utc alias to datetime.timezone.utc is removed.

This line seems to allow Django versions larger than v4, including v5

The build chooses Django 5:

Therefore it's an upstream issue at HyperKitty.

There are other open issues regarding time zone handling:

I have filed a new issue:

Until this is resolved, we could enforce a specific Django version by either patching the requirements file during the build, or by installing any other Django version lower than v5 that satisfies the version requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants