Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapsAPIGenericEngine uses HttpClient incorrectly #155

Open
stephajn opened this issue Sep 8, 2022 · 1 comment
Open

MapsAPIGenericEngine uses HttpClient incorrectly #155

stephajn opened this issue Sep 8, 2022 · 1 comment

Comments

@stephajn
Copy link

stephajn commented Sep 8, 2022

The MapsApiGenericEngine creates a new HttpClient for every request it makes. As a result, under load, this library would burn up all of the available sockets on a machine because it is not reusing the same HttpClient instance.

This class should be updated so that the HttpClient is created once as a static instance instead.

@maximn
Copy link
Owner

maximn commented Sep 8, 2022

Right, I believe it used to work differently in older versions.

You're welcome to suggest a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants