Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't detect touch request by PIV module #22

Open
stronny opened this issue Feb 17, 2021 · 4 comments
Open

Doesn't detect touch request by PIV module #22

stronny opened this issue Feb 17, 2021 · 4 comments

Comments

@stronny
Copy link

stronny commented Feb 17, 2021

Apologies for me being unclear whether the PIV is supported and I'm experiencing a bug or is this a planned feature?

@maximbaz
Copy link
Owner

Hello! This is not implemented, simply because I never used PIV module, but I definitely want to support this 🙂

Right now GPG detection is based on a bunch of hacks, ideally we should find a way to support CCID protocol, just like we already do with FIDO, then both GPG and PIV detection would just work. Problem is - I don't know enough of such low level stuff to implement this 😬

In any case, do you have a simple way to reproduce for me, what is the simplest command I could run to trigger touch request?

@stronny
Copy link
Author

stronny commented Feb 17, 2021

Generate a cert in 9a slot with touch policy enabled and open this https://server.cryptomix.com/secure/

@stronny
Copy link
Author

stronny commented Feb 17, 2021

Coming to think about it maybe it's less useful for traditional HTTPS flow, because depending on a setup it may require a touch for any and all requests, which will render the key unusable. Having said that, PIV detection would not be completely superfluous because I believe there are circumstances where this will still be useful, even for HTTPS (cert is only required for a "login" page that sets a cookie or somesuch).

@invidian
Copy link
Contributor

invidian commented Jan 5, 2022

Just a note, if you use PIV module for GPG, e.g using https://github.com/alonbl/gnupg-pkcs11-scd, then you will still get notified properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants