Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature ip address in campaign webhook #6539

Merged
merged 2 commits into from Nov 24, 2018

Conversation

dongilbert
Copy link
Member

@dongilbert dongilbert commented Sep 7, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? N
New feature? Y
Automated tests included? Y
Related user documentation PR URL mautic/documentation#296
Related developer documentation PR URL /
Issues addressed (#s or URLs) N/A
BC breaks? N
Deprecations? N

Description:

The send webhook campaign action can now work with {contactfield=ipAddress} which will return CSV of contact's IP addresses. Example campaign action setup:

screen shot 2018-08-24 at 17 52 29

Will return payload like this: test=tee&email=linhartescope+form2%40gmail.com&IP=127.0.0.1

Steps to test this PR:

  1. Create a campaign with the webhook action.
  2. Use the new token for IP addresses.
  3. Create a Request bin or similar webhook catcher.
  4. Run the campaign and check that the IP address token is converted to the correct value.

@dongilbert dongilbert added ready-to-test PR's that are ready to test enhancement Any improvement to an existing feature or functionality labels Sep 7, 2018
@dongilbert dongilbert added this to the 2.14.2 milestone Sep 7, 2018
@mleffler mleffler added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Sep 28, 2018
@mleffler
Copy link
Contributor

This has been code reviewed and has had one test pass.

@escopecz escopecz added this to Tested Once in Testing 2.14.2 Oct 2, 2018
@escopecz escopecz added the needs-documentation PR's that need documentation before they can be merged label Oct 8, 2018
@escopecz
Copy link
Sponsor Member

escopecz commented Oct 8, 2018

I will actually move this out of the bug fix version to the feature version 2.15.0. Don, add the documentation whenever you'll get a chance.

@escopecz escopecz modified the milestones: 2.14.2, 2.15.0 Oct 8, 2018
@escopecz escopecz removed this from Tested Once in Testing 2.14.2 Oct 8, 2018
@npracht npracht added this to Tested once in Testing 2.15.0 Oct 16, 2018
@npracht npracht moved this from Tested once to Pending feedback in Testing 2.15.0 Oct 16, 2018
@dongilbert
Copy link
Member Author

@escopecz You wrote this featured, I just created the PR. Can you add documentation please?

@escopecz escopecz removed the needs-documentation PR's that need documentation before they can be merged label Nov 12, 2018
@mleffler mleffler moved this from Pending feedback to Tested once in Testing 2.15.0 Nov 16, 2018
@mleffler
Copy link
Contributor

This has been tested and running in production for a while - ready to commit?

Copy link
Contributor

@Woeler Woeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Indeed ready to go.

@Woeler Woeler merged commit 6556987 into mautic:staging Nov 24, 2018
Testing 2.15.0 automation moved this from Tested once to Merged Nov 24, 2018
@Woeler Woeler removed the pending-test-confirmation PR's that require one test before they can be merged label Nov 24, 2018
@alanhartless alanhartless deleted the feature-ip-address-in-campaign-webhook branch April 18, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any improvement to an existing feature or functionality
Projects
No open projects
Testing 2.15.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants