Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Redundant “New” button in Companies Merge modal #13416

Open
andersonjeccel opened this issue Feb 20, 2024 · 13 comments · May be fixed by #13679
Open

[UX] Redundant “New” button in Companies Merge modal #13416

andersonjeccel opened this issue Feb 20, 2024 · 13 comments · May be fixed by #13679
Assignees
Labels
bug Issues or PR's relating to bugs companies Anything related to companies user-experience Anything related to related to workflows, feedback, and navigation user-interface Anything related to appearance, layout, and interactivity

Comments

@andersonjeccel
Copy link
Contributor

andersonjeccel commented Feb 20, 2024

The “New” button in the Companies Merge modal currently leads to additional menu options that show without content.
How to reproduce the bug:

  1. Open Companies
  2. Click to create a new
  3. Fill any information
  4. Click to merge
  5. The wrong modal is displayed

Image

Impact

It would eliminate unnecessary confusion caused by empty menu options and streamline the process of merging companies. It not only disrupts the workflow but also gives an impression of incomplete or faulty features.




Care about this issue? Want to get it resolved sooner? If you are a member of Mautic, you can add some funds to the Bounties Project so that the person who completes this task can claim those funds once it is merged by a member of the core team! Read the docs here.

@andersonjeccel andersonjeccel added bug Issues or PR's relating to bugs user-interface Anything related to appearance, layout, and interactivity user-experience Anything related to related to workflows, feedback, and navigation labels Feb 20, 2024
@abansal15
Copy link

Hello @andersonjeccel could you please assign this issue to me i will remove the confusion of the empty menu options by removing it quickly.

@andersonjeccel
Copy link
Contributor Author

andersonjeccel commented Feb 21, 2024

@abansal15 Done!
Remember that this issue happen only when the company is not saved yet. For already existing companies, when you edit, it works as expected.

@andersonjeccel andersonjeccel changed the title Redundant “New” button in Companies Merge modal [UX] Redundant “New” button in Companies Merge modal Feb 21, 2024
@andersonjeccel andersonjeccel added the companies Anything related to companies label Feb 27, 2024
@PiyushThapaa
Copy link

@andersonjeccel I want to work on this issue but struggling to find the source code... do you have any suggestions?

@andersonjeccel
Copy link
Contributor Author

@PiyushThapaa It's probably close to this path:

\app\bundles\LeadBundle\

Maybe this? Have to look
\app\bundles\LeadBundle\Controller\CompanyController.php

@PiyushThapaa
Copy link

@andersonjeccel can you explain me what kind of change you want
Removing the header that contain new button and dropdown??
Whole modal should be like edit's merge modal?

I have been trying for 4 days to solve this issue but because being new to php I am not able to understand how can this issue be solved

@andersonjeccel
Copy link
Contributor Author

@LordRembo Could you help us a bit here?

@LordRembo
Copy link
Contributor

I'm gonna let Tim tackle this one.

@mallezie
Copy link
Contributor

I did not find it either. My plan was actually to remove the 'Merge' button on the new company overview. This is not needed there IMO, and also solves the issue.

AFAICT the buttons are added through JS, but no idea where they get passed to the page.

@andersonjeccel
Copy link
Contributor Author

@escopecz Do you know something about this issue? We need some guidance to fix

@nishant-s7
Copy link

Hi there! I would like to work on this bug, but I'm unclear about the expected result. Should we remove the Merge button until the company is not saved?

@andersonjeccel
Copy link
Contributor Author

andersonjeccel commented Apr 8, 2024

@nishant-s7 I think the best approach would be what Tim said: when creating a new company, the Merge button must be hidden

thanks for catching this issue!

@andersonjeccel
Copy link
Contributor Author

@all-contributors please add @andersonjeccel for bug

Copy link
Contributor

@andersonjeccel

I've put up a pull request to add @andersonjeccel! 🎉

@nishant-s7 nishant-s7 linked a pull request Apr 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs companies Anything related to companies user-experience Anything related to related to workflows, feedback, and navigation user-interface Anything related to appearance, layout, and interactivity
Projects
Status: 🤔 To Do
Status: Todo
Development

Successfully merging a pull request may close this issue.

6 participants