New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Redundant “New” button in Companies Merge modal #13416
Comments
Hello @andersonjeccel could you please assign this issue to me i will remove the confusion of the empty menu options by removing it quickly. |
@abansal15 Done! |
@andersonjeccel I want to work on this issue but struggling to find the source code... do you have any suggestions? |
@PiyushThapaa It's probably close to this path: \app\bundles\LeadBundle\ Maybe this? Have to look |
@andersonjeccel can you explain me what kind of change you want I have been trying for 4 days to solve this issue but because being new to php I am not able to understand how can this issue be solved |
@LordRembo Could you help us a bit here? |
I'm gonna let Tim tackle this one. |
I did not find it either. My plan was actually to remove the 'Merge' button on the new company overview. This is not needed there IMO, and also solves the issue. AFAICT the buttons are added through JS, but no idea where they get passed to the page. |
@escopecz Do you know something about this issue? We need some guidance to fix |
Hi there! I would like to work on this bug, but I'm unclear about the expected result. Should we remove the Merge button until the company is not saved? |
@nishant-s7 I think the best approach would be what Tim said: when creating a new company, the Merge button must be hidden thanks for catching this issue! |
@all-contributors please add @andersonjeccel for bug |
I've put up a pull request to add @andersonjeccel! 🎉 |
The “New” button in the Companies Merge modal currently leads to additional menu options that show without content.
How to reproduce the bug:
Impact
It would eliminate unnecessary confusion caused by empty menu options and streamline the process of merging companies. It not only disrupts the workflow but also gives an impression of incomplete or faulty features.
Care about this issue? Want to get it resolved sooner? If you are a member of Mautic, you can add some funds to the Bounties Project so that the person who completes this task can claim those funds once it is merged by a member of the core team! Read the docs here.
The text was updated successfully, but these errors were encountered: