Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classes passed in form attributes are rendered with doubled quotation marks #13645

Open
1 task done
Aleen95 opened this issue Apr 12, 2024 · 1 comment
Open
1 task done
Labels
bug Issues or PR's relating to bugs mautic-5 Relates to Mautic 5.x T1 Low difficulty to fix (issue) or test (PR)
Milestone

Comments

@Aleen95
Copy link

Aleen95 commented Apr 12, 2024

Mautic Version

5.0.x series

Way of installing

Other (please specify if relevant in the bug report)

PHP version

8.1.2

What browsers are you seeing the problem on?

Chromium

What happened?

Version: 5.0.4
PHP version: 8.1.2
Installed in a self built docker-image

If you pass classes in the form attributes, they will be rendered in double quotes, breaking the styling.
Conversely, I need to pass the class without quotes (class=foobar instead of class="foobar"). However, this breaks the styling in the previous version of mautic (4.4), which is still in use.

image

image

How can we reproduce this issue?

Step 1: pass a class with quotes like class="foobar" into the form attributes
Step 2: Check the output with the developer-tools

Relevant log output

No response

Code of Conduct

  • I confirm that I have read and agree to follow this project's Code of Conduct




Care about this issue? Want to get it resolved sooner? If you are a member of Mautic, you can add some funds to the Bounties Project so that the person who completes this task can claim those funds once it is merged by a member of the core team! Read the docs here.

@Aleen95 Aleen95 added bug Issues or PR's relating to bugs needs-triage For new issues/PRs that need to be triaged labels Apr 12, 2024
@dsp76
Copy link

dsp76 commented Apr 20, 2024

Confirmed - altough in my test its slightly different result - overall the same issue:
image

@dsp76 dsp76 added T1 Low difficulty to fix (issue) or test (PR) mautic-5 Relates to Mautic 5.x and removed needs-triage For new issues/PRs that need to be triaged labels Apr 20, 2024
@escopecz escopecz added this to the 5.1.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs mautic-5 Relates to Mautic 5.x T1 Low difficulty to fix (issue) or test (PR)
Projects
None yet
Development

No branches or pull requests

3 participants