This code got rid of the error in the logs.
Can someone verify it?

The error message indicates that passing null as the $filename parameter to the fnmatch() function is deprecated. This is happening because the $origin variable may be null in some cases.

To fix this error, you can add a check to ensure that $origin is not null before calling fnmatch(). Here's an updated version of the code:

 // Check the domains using shell wildcard patterns
 $validCorsDomainFilter = function ($validCorsDomain) use ($origin) {
     if ($origin === null) {
         return false;
     }
     return fnmatch($validCorsDomain, $origin, FNM_CASEFOLD);
 };

 if (array_filter($this->validCORSDomains, $validCorsDomainFilter)) {
     $this->requestOriginIsValid = true;
     $this->corsHeaders['Vary']  = 'Origin';

     return $origin;
 }

 $this->requestOriginIsValid = false;

 return null;

This adds an additional check to ensure that $origin is not null before calling fnmatch(). If $origin is null, the filter will return false and the function will continue as before.

I just setup a new Mautic install for production and our logs are filled with this deprecation notice.

Looks like we have a fix in #13270 folks - please check and test, and remember to leave your review!

Docs here for how to review & test: https://mau.tc/tester (you can do it in the browser using Gitpod).

Thanks in advance for helping get this into a future release of Mautic!

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If this issue is continuing with the lastest stable version of Mautic, please open a new issue that references this one.