Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Custom fields view permission #13602

Open
1 task done
patrykgruszka opened this issue Apr 5, 2024 · 2 comments
Open
1 task done

Missing Custom fields view permission #13602

patrykgruszka opened this issue Apr 5, 2024 · 2 comments
Assignees
Labels
bug Issues or PR's relating to bugs custom-fields Anything related to custom fields regression A bug that broke something in the last release roles Anything related to users and roles
Milestone

Comments

@patrykgruszka
Copy link
Member

patrykgruszka commented Apr 5, 2024

Mautic Version

5.0.x series

Way of installing

I cloned the Mautic repo (not recommended or supported)

PHP version

8.2.4

What browsers are you seeing the problem on?

Not relevant

What happened?

In recent 5.x version there is missing permission setting for contact custom fields.

5.x branch:
image

5.0.3:
image

In result of this change introduced in #13321 I can no longer get the custom field list from API. The lead:fields:view is still used in the controller.

Related files:
https://github.com/mautic/mautic/pull/13321/files#diff-fc1c6863009fa9dbb412ad96ef474537d4e3d72c2ccc90f126e7bd808b0e45a7L64

How can we reproduce this issue?

  1. Go to the roles permission settings
  2. Select the Contact Permissions
  3. Check if the View permission is available

Relevant log output

{"errors":[{"code":403,"message":"The response has unexpected status code (403).\n\nResponse: {\"errors\":[{\"code\":403,\"message\":\"Permission not found. 'lead:fields:view' given.\",\"details\":[]}]}"}]}

Code of Conduct

  • I confirm that I have read and agree to follow this project's Code of Conduct




Care about this issue? Want to get it resolved sooner? If you are a member of Mautic, you can add some funds to the Bounties Project so that the person who completes this task can claim those funds once it is merged by a member of the core team! Read the docs here.

@patrykgruszka patrykgruszka added bug Issues or PR's relating to bugs needs-triage For new issues/PRs that need to be triaged regression A bug that broke something in the last release roles Anything related to users and roles custom-fields Anything related to custom fields and removed needs-triage For new issues/PRs that need to be triaged labels Apr 5, 2024
@patrykgruszka
Copy link
Member Author

@aarohiprasad Could you please take a look at this issue? Was it removed intentionally or by mistake?

@RCheesley
Copy link
Sponsor Member

@aarohiprasad could you please take a look at this one? It seems your PR has resulted in some unexpected changes to custom field permissions.

@RCheesley RCheesley added this to the 5.1.0 milestone Apr 29, 2024
@RCheesley RCheesley changed the title Missing Cusom fields view permission Missing Custom fields view permission Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs custom-fields Anything related to custom fields regression A bug that broke something in the last release roles Anything related to users and roles
Projects
None yet
Development

No branches or pull requests

3 participants