Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not be able to merge a company with itself! #12599

Open
1 task done
RCheesley opened this issue Jul 26, 2023 · 2 comments · May be fixed by #13578
Open
1 task done

Should not be able to merge a company with itself! #12599

RCheesley opened this issue Jul 26, 2023 · 2 comments · May be fixed by #13578
Assignees
@nishant-s7
Labels
bug Issues or PR's relating to bugs companies Anything related to companies good first issue hacktoberfest Issues that would be great for Hacktoberfest participants to work on T1 Low difficulty to fix (issue) or test (PR) user-experience Anything related to related to workflows, feedback, and navigation

Comments

@RCheesley
Copy link
Sponsor Member

Mautic Version

5.0.x series

PHP version

8

What browsers are you seeing the problem on?

Not relevant

What happened?

When you merge a company, a list of available companies is shown, including the current company.

https://watch.screencastify.com/v/jKUDaG5FYYq2TwoTKlHh

This is nonsensical - you would never be merging a company into itself!

How can we reproduce this issue?

Step 1: Open a company
Step 2: Select the option to merge with another company via the arrow at the top right next to close
Step 3: Notice that the current active company is being shown in the list - it should not be.

Relevant log output

N/A

Code of Conduct

  • I confirm that I have read and agree to follow this project's Code of Conduct
@RCheesley RCheesley added bug Issues or PR's relating to bugs needs-triage For new issues/PRs that need to be triaged user-experience Anything related to related to workflows, feedback, and navigation companies Anything related to companies T1 Low difficulty to fix (issue) or test (PR) good first issue and removed needs-triage For new issues/PRs that need to be triaged labels Jul 26, 2023
@RCheesley RCheesley added the hacktoberfest Issues that would be great for Hacktoberfest participants to work on label Oct 3, 2023
@nishant-s7
Copy link

Hi there! Can I work on this issue?

@RCheesley
Copy link
Sponsor Member Author

Hi @nishant-s7 - for sure. Please verify the issue first (as this was raised quite some time ago) and then check our docs: https://contribute.mautic.org/contributing-to-mautic/developer/code/pull-requests for how to make a PR. Please use the 5.x branch.

@nishant-s7 nishant-s7 linked a pull request Mar 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nishant-s7 nishant-s7

Labels
bug Issues or PR's relating to bugs companies Anything related to companies good first issue hacktoberfest Issues that would be great for Hacktoberfest participants to work on T1 Low difficulty to fix (issue) or test (PR) user-experience Anything related to related to workflows, feedback, and navigation
Projects
Hacktoberfest
Status: Todo
Open Source Fridays
Status: 🤔 To Do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cannot merge company with itself nishant-s7/mautic
2 participants
@RCheesley @nishant-s7