Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set $type to self::MAIN_REQUEST in handle method, IpRestrictMiddlewar… #13591

Closed
wants to merge 1 commit into from
Closed

Set $type to self::MAIN_REQUEST in handle method, IpRestrictMiddlewar… #13591

wants to merge 1 commit into from

Conversation

obamwonyi
Copy link
Contributor

…e class

Issue:#13576

Q A
Bug fix? (use the a.b branch) [x]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #13576

Description:

Steps to test this PR:

The implementation was made as

/**
This can also be implemented as $type = null, there for allowing the default to be used from the HttpKernelInterface interface
*/
$type = self:MAIN_REQUEST

kuzmany
kuzmany approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 🫰

@kuzmany kuzmany added the pending-test-confirmation PR's that require one test before they can be merged label Apr 2, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 5, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.04%. Comparing base (9aea3c9) to head (27a4c8c).
Report is 2 commits behind head on 5.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x   #13591      +/-   ##
============================================
- Coverage     61.04%   61.04%   -0.01%     
  Complexity    33938    33938              
============================================
  Files          2237     2237              
  Lines        101454   101454              
============================================
- Hits          61931    61929       -2     
- Misses        39523    39525       +2
Files Coverage Δ
app/middlewares/Dev/IpRestrictMiddleware.php 80.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

escopecz
escopecz requested changes Apr 5, 2024
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see this deprecated constant on multiple places. Please, replace it everywhere. We don't have to create a PR for each line.

@escopecz escopecz added the pending-feedback PR's and issues that are awaiting feedback from the author label Apr 5, 2024
@obamwonyi obamwonyi closed this Apr 12, 2024
@obamwonyi obamwonyi deleted the issue_#13576 branch April 12, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz requested changes

@kuzmany kuzmany kuzmany approved these changes

Assignees
No one assigned
Labels
pending-feedback PR's and issues that are awaiting feedback from the author pending-test-confirmation PR's that require one test before they can be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SELF:MASTER_REQUEST deprecated in app/middlewares/Dev/IpRestrictMiddleware.php directory.
3 participants
@obamwonyi @kuzmany @escopecz