Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SELF:MASTER_REQUEST deprecated in app/middlewares/Dev/IpRestrictMiddleware.php directory. #13576

Open
1 task done
Oluwatos94 opened this issue Mar 24, 2024 · 4 comments
Open
1 task done
Labels
bug Issues or PR's relating to bugs deprecation Includes deprecations good first issue T1 Low difficulty to fix (issue) or test (PR)

Comments

@Oluwatos94
Copy link

Oluwatos94 commented Mar 24, 2024

Mautic Version

5.0.x series

Way of installing

I cloned the Mautic repo (not recommended or supported)

PHP version

8.2

What browsers are you seeing the problem on?

Not relevant

What happened?

SELF:MASTER_REQUEST is deprecated need to be change to a new version SELF:MAIN_REQUEST.

How can we reproduce this issue?

Step 1: Navigate to app/middlewares/Dev/IpRestrictMiddleware.php directory then change to SELF:MAIN_REQUEST.
Screenshot (84)

Relevant log output

No response

Code of Conduct

  • I confirm that I have read and agree to follow this project's Code of Conduct




Care about this issue? Want to get it resolved sooner? If you are a member of Mautic, you can add some funds to the Bounties Project so that the person who completes this task can claim those funds once it is merged by a member of the core team! Read the docs here.

@Oluwatos94 Oluwatos94 added bug Issues or PR's relating to bugs needs-triage For new issues/PRs that need to be triaged labels Mar 24, 2024
@obamwonyi
Copy link
Contributor

Hi Oluwatos94, I would love to fix this issue, I will try to replicate the bug and see if I can fix it.

@Oluwatos94
Copy link
Author

Sure! @obamwonyi you can go ahead.

@RCheesley
Copy link
Sponsor Member

Following on from the comment on the PR, please change this in all locations rather than just one - PRs welcome!

@RCheesley RCheesley added T1 Low difficulty to fix (issue) or test (PR) deprecation Includes deprecations good first issue and removed needs-triage For new issues/PRs that need to be triaged labels Apr 29, 2024
@Oluwatos94
Copy link
Author

Okay, I will try and fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs deprecation Includes deprecations good first issue T1 Low difficulty to fix (issue) or test (PR)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants