Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect banner information displayed during multiple theme deletion #13570

Open
1 task done
code5rick opened this issue Mar 22, 2024 · 0 comments
Open
1 task done
Labels
bug Issues or PR's relating to bugs good first issue T1 Low difficulty to fix (issue) or test (PR) user-experience Anything related to related to workflows, feedback, and navigation

Comments

@code5rick
Copy link
Contributor

code5rick commented Mar 22, 2024

Mautic Version

5.0.x series

Way of installing

I downloaded a release from https://www.mautic.org/mautic-releases

PHP version

8.0.2

What browsers are you seeing the problem on?

Chrome

What happened?

When we insert custom email or landing pages on the Theme page and select more than two of them to be deleted, a banner appears indicating that one theme has been deleted. However, in reality, all selected themes are deleted.

The banner text should reference all the deleted themes instead of just one.

The delete feature itself functions correctly; it's only the message that needs improvement.

How can we reproduce this issue?

Step 1: Navigate to Settings > Themes
Step 2: Upload two custom themes on your Mautic instance.
Step 3: In the list of all themes, locate the checkbox beside each theme's name and select it.
image

Step 4: At the top of the list, click on "Delete Selected".
image

Step 5:A banner will appear. Click on "Delete" to confirm.
Step 6: A confirmation banner will appear, displaying only of the names of the deleted themes.

image

Relevant log output

None.

Code of Conduct

  • I confirm that I have read and agree to follow this project's Code of Conduct




Care about this issue? Want to get it resolved sooner? If you are a member of Mautic, you can add some funds to the Bounties Project so that the person who completes this task can claim those funds once it is merged by a member of the core team! Read the docs here.

@code5rick code5rick added bug Issues or PR's relating to bugs needs-triage For new issues/PRs that need to be triaged labels Mar 22, 2024
@andersonjeccel andersonjeccel added user-experience Anything related to related to workflows, feedback, and navigation and removed needs-triage For new issues/PRs that need to be triaged labels Apr 22, 2024
@RCheesley RCheesley added good first issue T1 Low difficulty to fix (issue) or test (PR) labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs good first issue T1 Low difficulty to fix (issue) or test (PR) user-experience Anything related to related to workflows, feedback, and navigation
Projects
Status: 🤔 To Do
Development

No branches or pull requests

3 participants