Package does not compile due to potential mismatch of "require" and "import" syntax

[mmartinezluis]

I'm using Nextjs V12. When trying to use the function-plot library via import statement, the library does not work. I get the below error:

There seems to be an import mismatch between the d3-shape dependency and the chart.js dependency. I would appreciate help on solving this issue.

[mauriciopoppe]

Thanks for the report, which version of function-plot are you using?

[mmartinezluis]

I'm using the latest version, 1.24.4

[mauriciopoppe]

I think it's happening because the dist files in dist/ emitted in v1.24.4 use CommonJS and the d3-* libraries use JS modules. So the flow is: JS Module (your app) -> CommonJS (function plot) -> JS Module (d3)

As a workaround try this import which uses a bundled version of function-plot which is the entire library in a single file:

import functionPlot from 'function-plot/dist/function-plot'

---

For the real solution the flow above needs to be JS Module (your app) -> JS Modlue (function plot) -> JS Module (d3). I switched to use JS modules in the master branch so you should be able to do import functionPlot from 'function-plot' in a future release.

[mmartinezluis]

Thank you for the response. I tried the work around, but it does not work:

It seems that this is a breaking change.

[mmartinezluis]

Since the documentaiton for Function-plot is solely written using JS Module syntax (and hence the users of Function-plot are more likely using ESM imports), I think that a new release for this seemingly breaking change should not be that difficult, given that you already updated the master branch for chart.js. I'll be looking forward to the release/fix. Thank you.

[mauriciopoppe]

I tried the following in a hello world parcel app and it did work:

import functionPlot from 'function-plot/dist/function-plot'

functionPlot({
  target: '#playground',
  data: [{ fn: 'x^2', graphType: 'polyline' }]
})

I suspect this might be a problem between the integration of the NextJS bundler and this library.

---

There's a dev build not ready for production usage that already uses JS modules, could you please try with this module? npm install function-plot@1.25.0-0

[mauriciopoppe]

Related issue in a NextJS app #217 that I think was never solved.

[mauriciopoppe]

I've reproduced this issue with the following steps:

• Follow this guide https://vercel.com/guides/create-hello-world-react-app-nextjs to create a hello world app
• Install function-plot v1.24.4
• Case 1: with the following setup I see the following error

import functionPlot from "function-plot";

⨯ ./node_modules/function-plot/dist/chart.js:7:19
Module not found: ESM packages (d3-shape) need to be imported. Use 'import' to reference the package instead. https://nextjs.org/docs/messages/import-esm-externals

https://nextjs.org/docs/messages/module-not-found

Import trace for requested module:
./node_modules/function-plot/dist/index.js
./src/app/page.js

• Case 2: if src/app/page.js look like this:

import functionPlot from "function-plot/dist/function-plot";

⨯ node_modules/function-plot/dist/function-plot.js (1:205) @ self
 ⨯ ReferenceError: self is not defined
    at eval (webpack-internal:///(rsc)/./node_modules/function-plot/dist/function-plot.js:4:3)
    at (rsc)/./node_modules/function-plot/dist/function-plot.js (/private/var/folders/c1/clfklx952gg7v4tjck2t8j640000gn/T/tmp.TNCiGCJfdr/hello-world/.next/server/vendor-chunks/function-plot.js:20:1)
    at __webpack_require__ (/private/var/folders/c1/clfklx952gg7v4tjck2t8j640000gn/T/tmp.TNCiGCJfdr/hello-world/.next/server/webpack-runtime.js:33:42)
    at eval (webpack-internal:///(rsc)/./src/app/page.js:9:90)
    at (rsc)/./src/app/page.js (/private/var/folders/c1/clfklx952gg7v4tjck2t8j640000gn/T/tmp.TNCiGCJfdr/hello-world/.next/server/app/page.js:194:1)
    at Function.__webpack_require__ (/private/var/folders/c1/clfklx952gg7v4tjck2t8j640000gn/T/tmp.TNCiGCJfdr/hello-world/.next/server/webpack-runtime.js:33:42)
    at runNextTicks (node:internal/process/task_queues:60:5)
    at listOnTimeout (node:internal/timers:540:9)
    at process.processTimers (node:internal/timers:514:7)

[mmartinezluis]

With dev build version 1.25.0, the package loads:

However, a new error shows on the application page:

The fix for the above error seems to be moving the "default" key from "exports" to the last place, as shown below:

[mauriciopoppe]

Thanks for the investigation, yes I saw a similar answer online, in addition I had to make a few changes to the dependencies included.

Anyways, first install the latest alpha version (not production ready yet) npm install function-plot@2.0.0-0.

The toy app I have looks like this:

"use client";

import React, { useRef, useEffect } from "react";
import functionPlot from "function-plot";
import styles from "./page.module.css";

export const FunctionPlot = React.memo(
  ({ options }) => {
    const rootEl = useRef(null);
    useEffect(() => {
      try {
        functionPlot(Object.assign({}, options, { target: rootEl.current }));
      } catch (e) {}
    });
    return <div ref={rootEl} />;
  },
  () => false,
);

export default function Home() {
  const options = {
    data: [{ fn: "x^2", graphType: "polyline" }],
  };
  return (
    <main className={styles.main}>
      <FunctionPlot options={options} />
    </main>
  );
}

[mmartinezluis]

Hi @mauriciopoppe ,

Thank you for the code. I just tested the code, and it shows an error:

The error comes at the "import" line:

import functionPlot from 'function-plot';

[SnowyField1906]

it has been a month and will there any update for this in near future?

[mauriciopoppe]

I tried the changes in #278 (comment) and they work for me, here's my setup:

cd $(mktemp -d)
npx create-next-app@latest
cd my-app
npm install function-plot@2.0.0-0
cat <<EOF > src/app/page.js
"use client";

import React, { useRef, useEffect } from "react";
import functionPlot from "function-plot";
import styles from "./page.module.css";

export const FunctionPlot = React.memo(
  ({ options }) => {
    const rootEl = useRef(null);
    useEffect(() => {
      try {
        functionPlot(Object.assign({}, options, { target: rootEl.current }));
      } catch (e) {}
    });
    return <div ref={rootEl} />;
  },
  () => false,
);

export default function Home() {
  const options = {
    data: [{ fn: "x^2", graphType: "polyline" }],
  };
  return (
    <main className={styles.main}>
      <FunctionPlot options={options} />
    </main>
  );
}
EOF
npm run dev

When I open the dev webpage I see no errors