Improve search box by adding autofocus (Desktop) / ability to clear search when expected #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImSanae
added a commit
to ImSanae/StickerPicker
that referenced
this pull request
Apr 13, 2023
ImSanae
added a commit
to ImSanae/StickerPicker
that referenced
this pull request
Apr 13, 2023
Merge from maunium#46 and maunium#49 added more stickers
ImSanae
added a commit
to ImSanae/StickerPicker
that referenced
this pull request
Apr 14, 2023
Merge from maunium#46 and maunium#49 added more stickers
ImSanae
added a commit
to ImSanae/StickerPicker
that referenced
this pull request
Apr 14, 2023
Merge from maunium#46 and maunium#49 added more stickers
ImSanae
added a commit
to ImSanae/StickerPicker
that referenced
this pull request
Apr 15, 2023
Merge from maunium#46 and maunium#49 added more stickers
salixor
force-pushed
the
feat/search-focus
branch
from
f090cc0
to
e2fffe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to close #42, #43 and #44 !
What's new ?
I tried to implement the autofocusing on Android as well. During testing, I found out that even though the field gets focused, the keyboard doesn't show up. This behaviour seems to be intended. I don't have an iOS device on hand to try, but it appears the behaviour is the same, so I didn't implement it on that OS either.