Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in Tumbnail module #66

Open
Barahten opened this issue Apr 20, 2020 · 4 comments · May be fixed by #86
Open

Error in Tumbnail module #66

Barahten opened this issue Apr 20, 2020 · 4 comments · May be fixed by #86
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Barahten
Copy link

Apparently the parsing process has some kind of error, if a sprite is specified in the VTT file relative to the VTT file, then the player loads the sprite relative to the root of the site
2020-04-20-205114
2020-04-20-205250

In the case that is provided in the screenshot, the tooltip.jpg file and tooltip.vtt are next to each other in the same folder
@matvp91 matvp91 added the bug Something isn't working label Apr 20, 2020
@matvp91
Copy link
Owner

matvp91 commented Apr 20, 2020

I've never taken relative url's into account when parsing the vtt file. You're right, it's better to resolve the thumbnail url's relative to where the vtt file is located. I'll have this one shipped with 1.5.1 once it arrives (no clear timeline as I've been working on this project on my free time). I'd also happily accept a PR if needed.

@Barahten
Copy link
Author

Barahten commented Apr 20, 2020 •
edited

I'd also happily accept a PR if needed.

I do not speak English very well, but what did you mean by that phrase?

@matvp91
Copy link
Owner

matvp91 commented Apr 20, 2020 •
edited

I'm sorry, no worries. :-) I'd be happy to accept a pull request (PR). It's basically a way for others to contribute to indigo-player. (See Pull Requests in the navigation bar above).

@matvp91 matvp91 added the good first issue Good for newcomers label Apr 20, 2020
@Barahten
Copy link
Author

I apologize if I ask in the wrong place: where and how can I enter a new setting for the player and then get its value from anywhere in the application?

JamoDevNich added a commit to JamoDevNich/indigo-player that referenced this issue Mar 1, 2021
@JamoDevNich
Use thumbnail path relative to the VTT file
cb640aa 
This fix loads sprites relative to the location of the VTT file, unless a direct URL is specified in the VTT  

Resolves matvp91#66 where a thumbnail sprite is loaded from the website root
@JamoDevNich JamoDevNich linked a pull request Mar 1, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use thumbnail path relative to the VTT file JamoDevNich/indigo-player
2 participants
@matvp91 @Barahten