Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CocoaPods subspec for library without Keychain library #114

Open
ziogaschr opened this issue Nov 22, 2016 · 2 comments
Open

Add CocoaPods subspec for library without Keychain library #114

ziogaschr opened this issue Nov 22, 2016 · 2 comments

Comments

@ziogaschr
Copy link
Contributor

Hello @mattrubin and thanks for building this awesome library.

We want to use your lib in a project with some different needs for the Keychain storage implementation.

I have already implemented the lib with our own library for Keychain persistance and works great, although I had to manually add the files into my project in order I skip the Keychain.swift.

Would you accept a PR that adds a new subspec for CocoaPods without Keychain lib?
You can check what I mean here

@mattrubin
Copy link
Owner

I'd be happy to take a look at a PR adding a subspec. I'm curious, though, why it's necessary. Does including the keychain functionality of the current library cause problems, or are you simply trying to avoid including code you never use?

@ziogaschr
Copy link
Contributor Author

Thanks a lot for welcoming a PR. I want to avoid including the code as I don’t use it.
I have already played with it, but the current version of CocoaPods breaks the CommonCrypto handling. I will have a look and make a PR once ready. :)

On 22 Nov 2016, at 17:38, Matt Rubin <notifications@github.commailto:notifications@github.com> wrote:

I'd be happy to take a look at a PR adding a subspec. I'm curious, though, why it's necessary. Does including the keychain functionality of the current library cause problems, or are you simply trying to avoid including code you never use?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/114#issuecomment-262274290, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAw_jJ6CBDB5biaobiT-K28wyME9dd6qks5rAwxegaJpZM4K5F6D.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants