Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inheriting from jsonld-signatures abstract classes #81

Open
tplooker opened this issue Sep 21, 2020 · 1 comment
Open

Remove inheriting from jsonld-signatures abstract classes #81

tplooker opened this issue Sep 21, 2020 · 1 comment

Comments

@tplooker
Copy link
Member

tplooker commented Sep 21, 2020

Because jsonld-signatures is un-typed (written in JS) and this library leverages types through typescript when inheriting from an un-typed abstract based class the TS compiler is essentially blind. To improve the development experience we should sever this dependency and do one of the following

  1. Define our own base classes but in typescript
  2. Depend on types defined in transmutes version
  3. Dont define an abstract base class and just define the remaining API's directly in the signature suite classes.

See here for an example

@kdenhartog kdenhartog self-assigned this Sep 21, 2020
@kdenhartog kdenhartog mentioned this issue Nov 4, 2020
8 tasks
@kdenhartog
Copy link
Contributor

This has turned into a larger issue. jsonld.js needs to be properly typed first and so does jsonld-signatures before this suite can be defined. Otherwise there's likely to be typing conflicts in this library.

kdenhartog added a commit that referenced this issue Dec 10, 2020
@kdenhartog kdenhartog removed their assignment May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants