Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deriveProof does not support blank node identifiers for credentialSubject #151

Open
OR13 opened this issue Aug 12, 2021 · 5 comments
Open

Comments

@OR13
Copy link

OR13 commented Aug 12, 2021

Originally discovered by @brianorwhatever

See is reproduction here:

transmute-industries/verifiable-data#76

Surfacing from the linked PR description:

Related issues:

Questions:

  1. Is it possible to use deriveProof on a credential with no credentialSubject.id? this example implies that it should be possible...
@OR13
Copy link
Author

OR13 commented Aug 12, 2021

Current hypothesis is that is may be VC related by not LD Suite related... working to confirm that on the linked PR.

@brianorwhatever
Copy link

I have attempted to recreate with just the linked data proof from example 12 above and ran into an issue with the id already being a node identifier
image (1)
removing the id derived a proof properly however I'm now running into a internal error in Neon module: index out of bounds: the len is 5 but the index is 5 problem on verification

@OR13
Copy link
Author

OR13 commented Aug 14, 2021

@tmarkovski
Copy link
Contributor

What's the suggested fix to this issue? Force the use of id in credentialSubject?

@tplooker
Copy link
Member

@tmarkovski that would be a suggested interim solution however the long term solution is a revision to the proof suite that accounts for this case in the URDNA algorithm. Given the recent consensus we have had around decentralized-identity/bbs-signature#10 I'm working on an updated implementation that incorporates this among various other changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants