Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various warnings when bundling with CRA #109

Open
OR13 opened this issue Feb 27, 2021 · 2 comments
Open

Various warnings when bundling with CRA #109

OR13 opened this issue Feb 27, 2021 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@OR13
Copy link

OR13 commented Feb 27, 2021

./node_modules/@transmute/did-key-bls12381/node_modules/@mattrglobal/bbs-signatures/lib/wasm.js
Critical dependency: the request of a dependency is an expression

./node_modules/@transmute/did-key-bls12381/node_modules/@mattrglobal/node-bbs-signatures/lib/bls12381.js
Critical dependency: the request of a dependency is an expression

./node_modules/@transmute/did-key-bls12381/node_modules/@mattrglobal/node-bbs-signatures/lib/bls12381toBbs.js
Critical dependency: the request of a dependency is an expression

./node_modules/@transmute/did-key-bls12381/node_modules/@mattrglobal/node-bbs-signatures/lib/bbsSignature.js
Critical dependency: the request of a dependency is an expression

./node_modules/@mattrglobal/node-bbs-signatures/lib/bls12381.js
Critical dependency: the request of a dependency is an expression

./node_modules/@mattrglobal/node-bbs-signatures/lib/bls12381toBbs.js
Critical dependency: the request of a dependency is an expression

./node_modules/@mattrglobal/node-bbs-signatures/lib/bbsSignature.js
Critical dependency: the request of a dependency is an expression
@tplooker tplooker added the help wanted Extra attention is needed label May 26, 2021
@tplooker
Copy link
Member

An easier way to replicate this issue is by running the basic browser sample, for some reason web-pack is insisting on installing the optional dependency of node-bbs-signatures that is for when a consumer of bbs-signatures is running in Node and would like the performance boost of executing via a native node module. I thought by specifying a seperate index.js for browser this issue would have been resolved however it appears node-bbs-signatures is still being brought in somehow.

@kdenhartog
Copy link
Contributor

Seems like based on the documentation the browser property in the package.json file is a hint rather than an indicator of picking up only certain files. Maybe that has something to do with it?

https://docs.npmjs.com/cli/v7/configuring-npm/package-json#browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Development

No branches or pull requests

3 participants