Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS already supports this #30

Open
breun opened this issue Jul 21, 2018 · 3 comments
Open

macOS already supports this #30

breun opened this issue Jul 21, 2018 · 3 comments

Comments

@breun
Copy link

breun commented Jul 21, 2018

Although this is a cool project, if you add the following line to the top of /etc/pam.d/sudo there is no need to replace sudo:

auth       sufficient     pam_tid.so

It might be nice to point this out in the README.

@DenWav
Copy link

DenWav commented Aug 15, 2018

Wow, thanks for the tip! Been using this since I got my MacBook, cool to see a native solution exists.

@lucasjohnston
Copy link

lucasjohnston commented Aug 25, 2018

You're right to point out that macOS already supports TouchID with sudo, but to do so requires a system config change (editing your /etc/pam.d/sudo file).
This means that you will not be able to use sudo when SSHing in, because you can't send your fingerprint through the internet

Also, I'd generally lean towards avoiding editing core system config files if possible, but that's just my personal opinon! The way I use this project is by building the binary with a different name (I personally use lucasudo 😉) and sticking it in /usr/local/bin. Doing this means I'm not overriding my system's sudo, which imo is a safer option - and allows me to continue using sudo over SSH.

This is down to personal preference really, but I completley agree that pointing out both options in the readme would be a good idea.

@rkujawa
Copy link

rkujawa commented Nov 26, 2018

@lucasjohnston You can still use sudo over ssh even if you enable this, since pam_tid.so in the example above is marked as "sufficient". I.e. it is allowed to fail and the authentication mechanism will happily fall through to the next module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants