Skip to content
This repository has been archived by the owner on Mar 5, 2023. It is now read-only.

withConfig not typed correctly and withContext method missing from generated machine types #92

Open
bahalperin opened this issue Jul 5, 2021 · 0 comments

Comments

@bahalperin
Copy link

In xstate, withConfig is typed with context as a second, optional parameter. In xstate-codegen, the generated signature for withConfig lets you pass in context in the same object as the rest of the machine options. This ends up getting silently ignored and leads to confusing behavior.

The generated machines are also missing the withContext method. Typescript uses the original xstate method, which results in a type error because it returns the StateMachine type from xstate and not the generated machine type from xstate-codegen.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant