Skip to content
This repository has been archived by the owner on Mar 5, 2023. It is now read-only.

Type support for useActor #70

Open
danielkcz opened this issue Jan 5, 2021 · 0 comments
Open

Type support for useActor #70

danielkcz opened this issue Jan 5, 2021 · 0 comments
Assignees

Comments

@danielkcz
Copy link

Let's discuss this as a new issue and close #48 since it seems like a much more complicated problem.

The useActor alone has 3 overloads around some getSnapshot which I don't fully understand yet.

https://github.com/davidkpiano/xstate/blob/07980daa33e6ea4094ca11ab4d25b23175104cb7/packages/xstate-react/src/useActor.ts#L30-L42

Then there is ActorRefFrom which can get ActorRef type based on the machine. That's currently incompatible with generated classes extended from StateNodeWithGeneratedTypes.

https://github.com/davidkpiano/xstate/blob/07980daa33e6ea4094ca11ab4d25b23175104cb7/packages/core/src/types.ts#L1261-L1267

I can imagine we could ideally generate direct MachineIdActorRef types, but I am not sure how to approach that.

@mattpocock Can you please have a look at it and perhaps make a Loom again with hints?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants