Change TRUNCATE to DELETE FROM in postgres database #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This actually isn't a problem for postgres but is a problem for cockroach. Internally cockroach drops the table when running a truncate which causes the insert to fail inside of this transaction. I added repro steps to mattes/migrate#320 which this PR should close. Closes: mattes/migrate#320 Signed-off-by: Elliott Davis <elliott@excellent.io>
elliott-davis
pushed a commit
to chuckleheads/hurtlocker
that referenced
this pull request
May 22, 2018
The long and the short of this is there were multiple errors with parsing configs and running migrations. What you need to know: There is a patched vendor file (shame on me, I know). However, being the nice netizen that I am, I made a PR upstream golang-migrate/migrate#36 The other stuff is mostly cleanup around how viper serializes config files and some bad quoting on my part in originsrv. Signed-off-by: Elliott Davis <elliott@excellent.io>
elliott-davis
pushed a commit
to chuckleheads/hurtlocker
that referenced
this pull request
May 22, 2018
The long and the short of this is there were multiple errors with parsing configs and running migrations. What you need to know: There is a patched vendor file (shame on me, I know). However, being the nice netizen that I am, I made a PR upstream golang-migrate/migrate#36 The other stuff is mostly cleanup around how viper serializes config files and some bad quoting on my part in originsrv. Signed-off-by: Elliott Davis <elliott@excellent.io>
|
I'm closing this because I didn't realize I should be using: Apologies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This actually isn't a problem for postgres but is a problem for cockroach.
Internally cockroach drops the table when running a truncate which causes the insert to fail inside of this transaction. I added repro steps to mattes/migrate#320 which this PR should close.
Closes: mattes/migrate#320
Signed-off-by: Elliott Davis elliott@excellent.io