Implement --votes=0 setting to vote all options even if adding an option #506
Conversation
kaakaa
added
Type/Enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #506 +/- ##
==========================================
- Coverage 93.27% 93.19% -0.09%
==========================================
Files 13 13
Lines 1650 1630 -20
==========================================
- Hits 1539 1519 -20
Misses 84 84
Partials 27 27 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Should we bump the minimum server version to v9.3.0 so it includes mattermost/mattermost#24916?
| votedAnswers := poll.GetVotedAnswers(userID) | ||
| remains := poll.Settings.MaxVotes - len(votedAnswers) | ||
| if poll.Settings.MaxVotes == 0 { | ||
| remains = len(poll.AnswerOptions) - len(votedAnswers) |
There was a problem hiding this comment.
0/5 do we even want to show the number of remaining votes?
There was a problem hiding this comment.
Not required, but I think that giving feedback on how many options users have already voted for (= remaining votes) is better than nothing.
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
|
It seems to me that v9.3 is too new and I concerned that a number of users could be unable to launch Matterpoll v1.7. mattermost/mattermost#24916 occurs only in dialog, not in command, so ESR v8.1 (or v7.8) looks better. |
fixes #496
refs #372
--votes=0setting allows users to vote all options even after adding an option.Notes: When creating a poll from interactive dialog,
0cannot be set toNumber of Votesdue to mattermost's issue. Until resolving it,--votes=0setting can be used only from/pollcommand.