Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upon subscribing to a feed, fetch the latest entry #806

Open
HarHarLinks opened this issue Aug 7, 2023 · 3 comments · May be fixed by #809
Open

Upon subscribing to a feed, fetch the latest entry #806

HarHarLinks opened this issue Aug 7, 2023 · 3 comments · May be fixed by #809
Assignees
@tadzik
Labels
Feeds Involves the RSS feed service. T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements.

Comments

@HarHarLinks
Copy link
Contributor

As a user of feeds, I am used to my reader fetching and showing me at least the couple latest entries in the feed.
Hookshot however just subscribes, and only posts new posts that appear from that point on.

I suggest changing the behavior such that upon subscribing, hookshot posts the latest entry in the feed.
@Half-Shot Half-Shot added Feeds Involves the RSS feed service. T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements. labels Aug 14, 2023
@Half-Shot
Copy link
Contributor

I must admit I've heard the feedback over and over that it's weird that it does nothing on subscribe. I agree fetching the first item sounds sane.

@HarHarLinks HarHarLinks changed the title Upon subscribing to a feed, fetch the last entry Upon subscribing to a feed, fetch the latest entry Aug 14, 2023
@tadzik tadzik self-assigned this Aug 18, 2023
@tadzik
Copy link
Contributor

tadzik commented Aug 18, 2023

This'd come with an odd side-effect when Redis is not in use.

Redis is currently used as a storage for already seen feed entries. If not configured, we store those in memory, and forget them on every restart. Then, when feeds are checked for the first time on startup, we assume to be doing the "initial sync", and we don't report feed items.

With this change in, hookshot would, on startup, (re)post the latest feed item for every feed to every room. We could make this feature configurable, but perhaps it'd be smarter for FeedReader to detect if it's running in non-persistent mode and figure it out by itself.

@tadzik tadzik linked a pull request Aug 18, 2023 that will close this issue
Open
1 task
@bkil
Copy link

bkil commented Aug 23, 2023

Somewhat related #768

This was referenced Feb 12, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tadzik tadzik

Labels
Feeds Involves the RSS feed service. T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Report the latest feed entry when fetching a feed for the first time matrix-org/matrix-hookshot
4 participants
@tadzik @bkil @Half-Shot @HarHarLinks