Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dochian Channels With mpl_Finance #596

Open
DrChandrakant opened this issue Mar 9, 2023 · 6 comments
Open

Dochian Channels With mpl_Finance #596

DrChandrakant opened this issue Mar 9, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@DrChandrakant
Copy link
Contributor

Those Who Looks For Dochian Channel with mpl_finance

NIFTY_2023-03-09_14-09-42

import OfflineData # Function Fetch Data From Mysql Stored Candle
import pandas_ta as ta
import mplfinance as mpl
df = OfflineData.getStockData('tcs')
df.tail(2)
Id Open High Low Close Volume

348.0 | 3361.9 | 3404.95 | 3359.00 | 3378.0 | 1333840.0
349.0 | 3364.0 | 3396.00 | 3330.85 | 3390.4 | 1844590.0

donchiandf = ta.donchian(df["High"], df["Low"], lower_length=10, upper_length=15)
donchiandf.tail(2)

DCU = donchiandf[['DCU_10_15']]
DCM = donchiandf[['DCM_10_15']]
DCL = donchiandf[['DCL_10_15']]

apds = [
    mpl.make_addplot(DCU,color='#2962FF',panel=0,),
    mpl.make_addplot(DCM,color='#FF6D00',panel=0,),
    mpl.make_addplot(DCL,color='#2962FF',panel=0,),
]

mpl.plot(
    df,
    volume=True,
    type="candle",
    style="yahoo",
    addplot=apds,
    figscale=1.2,
    figsize=(46,26,)
)

dochian

@DrChandrakant DrChandrakant added the enhancement New feature or request label Mar 9, 2023
@alexpvpmindustry
Copy link
Contributor

alexpvpmindustry commented Apr 14, 2023

cool, but i dont think is considered an enhancement.
do you mean to have this implemented in mplfinance?

@DrChandrakant
Copy link
Contributor Author

cool, but i dont think is considered an enhancement. do you mean to have this implemented in mplfinance?

This Guidance Code for People who Search For It Should Be Part of the Example section.

@alexpvpmindustry
Copy link
Contributor

alexpvpmindustry commented Apr 14, 2023

ok then maybe this should not be open... its not an issue.
maybe a community/example notebook?
you want to help create one? @DrChandrakant

@DrChandrakant
Copy link
Contributor Author

DrChandrakant commented Apr 14, 2023

ok then maybe this should not be open... its not an issue. maybe a community/example notebook? you want to help create one? @DrChandrakant

Yes I Want to Add This And Many More Indicator I have Prepared For the community/example notebook it will great help for many users

@alexpvpmindustry
Copy link
Contributor

u know how to make a pull request in github?

@DrChandrakant
Copy link
Contributor Author

Okay I Will Try It pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants