Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on empty vec. (mathjax/MathJax#3195) #1066

Closed
wants to merge 1 commit into from

Conversation

tsutaj
Copy link

@tsutaj tsutaj commented Feb 26, 2024

@dpvc
Copy link
Member

dpvc commented Mar 3, 2024

We don't make individual adjustments to the AsciiMath code, but rather, when a new version is released, we update the AsciiMath code to the current version of AsciiMath all at once. The AsciiMath input jax needs to be updated to be an actual v3 one rather than the hack that patches in the legacy v2 version. In any case, as we are not updating the v2 legacy code here, as the v2 version is the primary version for this, and we take the legacy version here from that.

@dpvc
Copy link
Member

dpvc commented Mar 3, 2024

Closing this PR, since it will be taken care of when AsciiMath is updated in the next v2 version, or when an actual v3 input jax is created.

@dpvc dpvc closed this Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashing when using empty vec() of AsciiMath
2 participants