Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing of panes doesn't work since update to Gnome 44.1 #963

Open
1 task
speightashley opened this issue Jun 4, 2023 · 8 comments
Open
1 task

Resizing of panes doesn't work since update to Gnome 44.1 #963

speightashley opened this issue Jun 4, 2023 · 8 comments

Comments

@speightashley
Copy link

Describe the bug
Maximise works fine. The issue comes when we go into a tiling mode that shares real estate. I code on the left with a bigger pane than on the right which is generally a browser to see what I build in real time. When hovering over the split line, when I drag to resize, it no longer does it and just stays static. It tries to do it based on the content resizing in the windows but it keeps the same dimensions for VSCode and Firefox.

Expected behavior
Window on the left gets bigger when dragging to the right / window on the right gets smaller.

To Reproduce

  • Occurs on:
    • X.Org
    • [ X ] Wayland
  • GNOME Shell version: 44.1
  • Distro: Manjaro
@ademoverflow
Copy link

Same thing since the update .. very annoying :(

@Luctins
Copy link

Luctins commented Jun 11, 2023

Same thing here with Fedora 38, Gnome Shell 44.2 @ 89f460b (current HEAD, installed from source).

EDIT: On applying the fix from #964, I can now resize windows, just not the first one and the drag radius is very small.

EDIT 2: Setting BORDER_WIDTH to someting like 6, makes resizing doable, because the black separator is now thicker and easy to select, like so:

diff --git a/src/layout/msWorkspace/tilingLayouts/baseResizeableTiling.ts b/src/layout/msWorkspace/tilingLayouts/baseResizeableTiling.ts
index 87ac6f4..9eaa1c8 100644
--- a/src/layout/msWorkspace/tilingLayouts/baseResizeableTiling.ts
+++ b/src/layout/msWorkspace/tilingLayouts/baseResizeableTiling.ts
@@ -19,7 +19,8 @@ import { MsWorkspace, Tileable } from '../msWorkspace';
 /** Extension imports */
 const Me = imports.misc.extensionUtils.getCurrentExtension();

-const BORDER_WIDTH = 2;
+const BORDER_WIDTH = 6;
+
 @registerGObjectClass
 export class BaseResizeableTilingLayout<
     S extends { key: string }
diff --git a/src/utils/windows.ts b/src/utils/windows.ts
index 2787b37..f5f6f00 100644

So it goes from something like this:
image

To this:
image

@ademoverflow
Copy link

Any update on this ?

@PapyElGringo
Copy link
Collaborator

Yeah sorry for the delay. I'm aware of the issue and it's because Gnome removed an API from Mutter that allowed us to listen to window events and allowed us to take priority on it to make our resize or Drag and drop features.

I already talked to them about it and they said it wasn't a valid use case so I can't simply fix it. I need to find an alternative strategy and make a rework of those features until another thing break...

Since it's still planned to work on our own WM is the short future I'm not sure I'll dig into it for the extension

@donalffons
Copy link

donalffons commented Jul 1, 2023

Thanks @PapyElGringo for your great work on this project.

Since it's still planned to work on our own WM is the short future I'm not sure I'll dig into it for the extension

Could you clarify what this means? Are you working on a "Material Shell" Window Manager as an alternative to Gnome? Or what is "the short future"?

@mempler
Copy link

mempler commented Jul 5, 2023

Since it's still planned to work on our own WM is the short future I'm not sure I'll dig into it for the extension

will it be X11 based or will it be Wayland based ?
I would love to see the future of this project.

actually, i might even recommend doing a hard fork of mutter to patch in the missing features that are required.

@ademoverflow
Copy link

Any update on this issue ?

@Luctins
Copy link

Luctins commented Dec 26, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants