Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons' appearance in disabled fieldset #5562

Open
datvm opened this issue Apr 2, 2024 · 2 comments · May be fixed by #5563
Open

Buttons' appearance in disabled fieldset #5562

datvm opened this issue Apr 2, 2024 · 2 comments · May be fixed by #5563

Comments

@datvm
Copy link
Contributor

datvm commented Apr 2, 2024

What is affected?

Component

Description

When a button or icon button is in a disabled fieldset, it correctly does not trigger click event. However, the appearance is not changed to match:

image

Reproduction

Lit Playground

Workaround

We have to manually keep track of the buttons' state and disable/enable each of them.

Is this a regression?

No or unsure. This never worked, or I haven't tried before.

Affected versions

1.4.0

Browser/OS/Node environment

Browser: Google Chrome Version 123.0.6312.86 (Official Build) (64-bit)

OS: Windows 11

@asyncLiz
Copy link
Collaborator

asyncLiz commented Apr 2, 2024

This is probably due to button not implementing formDisabledCallback()

@datvm
Copy link
Contributor Author

datvm commented Apr 3, 2024

Interesting, I believe this is related to #5049. I thought it was completed because the click behavior is working correctly with fieldset. Right now the styling is depending on [disabled]. I think it should be changed to :disabled instead.

I have created 2 PRs. If both PRs are approved it should fix this and #5049 as well.

@datvm datvm linked a pull request Apr 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants