Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MaterialToolbar] Subtitle is cut off when font-size is increased via accessibility options #4101

Open
d4rken opened this issue Mar 14, 2024 · 1 comment

Comments

@d4rken
Copy link

d4rken commented Mar 14, 2024

Description:

When the font-size is increased via the system accessibility settings (fontScale), then the subtitle is being cutoff on the bottom despite using wrap_content on the toolbar.

Screenshot from 2024-03-14 16-15-47
Screenshot from 2024-03-14 16-15-22
Screenshot from 2024-03-14 16-21-17

Expected behavior:

Toolbar should grow in height and keep the default paddings, and center the title/subtitle combo.

Source code:

https://github.com/d4rken-org/sdmaid-se/blob/e10ade68a4e2cae6cccf963862c318e29ba3acf7/app/src/main/res/layout/appcontrol_list_fragment.xml#L8

https://github.com/d4rken-org/sdmaid-se/blob/e10ade68a4e2cae6cccf963862c318e29ba3acf7/app/src/main/res/values/styles.xml#L194

Android API version:

AFAIK, all versions, I tested on Android 13 and 14.

Material Library version:
`1.11.0

Device:
Pixel 6 (and others)

@d4rken d4rken added the bug label Mar 14, 2024
@d4rken d4rken changed the title [MaterialToolbar] Subtitle is cut off when font-size is increased [MaterialToolbar] Subtitle is cut off when font-size is increased via accessibility options Mar 14, 2024
d4rken added a commit to d4rken-org/sdmaid-se that referenced this issue Mar 14, 2024
Was an attempt at fixing:
material-components/material-components-android#4101

Not fixed, but let's keep the updated dependencies.
@drchen
Copy link
Contributor

drchen commented Mar 14, 2024

Unfortunately I think it's a general issue to deal with font scales. Paul, do you know if we have any plans to solve this on Views? (Adaptive components on Compose will solve this, btw.)

d4rken added a commit to d4rken-org/sdmaid-se that referenced this issue Mar 15, 2024
Was an attempt at fixing:
material-components/material-components-android#4101

Not fixed, but let's keep the updated dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants