Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow admins to configure instance favicon and logo #29987

Closed
renchap opened this issue Apr 18, 2024 · 1 comment · Fixed by #30040
Closed

Allow admins to configure instance favicon and logo #29987

renchap opened this issue Apr 18, 2024 · 1 comment · Fixed by #30040

Comments

@renchap
Copy link
Sponsor Member

renchap commented Apr 18, 2024

Preliminary note

This issue is part of our "help wanted" issues. It represents something that we know we want to implement, and that is defined enough that a contributor can implement it in a way that it would get merged.

If you want to work on this, please add a comment saying so and ask any questions you need, then open a PR referencing this issue!

Description

At the moment, admins can not change the logo or favicon for their instance, as those are statically generated by the branding:generate_app_icons rake task.

We would like an admin to be able to go to "Administration > Server settings > Appearance", select an app icon and a base favicon (SVG files, feel free to add support for PNG maybe?), have the backend process them similar to what the rake task currently does, and store those files into the media storage.

If those files exist, then they should be used by the application.

This would solve #7396

Implementation notes

It may be needed to store a server setting for this, so there is a way to know that these icons have been installed (and maybe store their path in the setting?).

This may be similar to how the Mascot is currently implemented.

Those icons are used in app/views/layouts/application.html.haml and app/serializers/manifest_serializer.rb.

They should probably be moved to a helper and not be directly embedded in those files as the code will become a bit more complex.

It might be a good occasion to review the header and manifest to ensure that every icon recommended nowadays is here.

@renchap renchap changed the title Admin-configurable favicon and logo Allow admins to configure instance favicon and logo Apr 18, 2024
@FawazFarid
Copy link
Contributor

Looking to pick this up 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants