Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate annotation on sidekiq preventing flux install #61

Closed

Conversation

funkypenguin
Copy link

Hi folks,

This PR simple fixes #48, resolving the duplicate annotation which will cause the chart to fail to install when using fluxcd (and presumably others, although cli helm seems to ignore duplicates)

Cheers! :)
D

Signed-off-by: David Young <davidy@funkypenguin.co.nz>
Copy link
Sponsor

@jahanson jahanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this on my own fluxcd cluster just now and it fixed my problem I was having deploying the helm chart.

Copy link

@nrdufour nrdufour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is indeed fixing the issue in flux.

samcday added a commit to samcday/mastodon-chart that referenced this pull request Apr 28, 2023
dictvm pushed a commit to enoki-coop/helm-charts that referenced this pull request Jul 21, 2023
@timetinytim
Copy link
Contributor

Closing as this was fixed in another PR! (Sorry for the delay in getting around to this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate annotation in deployment-sidekiq
4 participants