Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove classes Minilogger and Pipe #6

Open
gogo2464 opened this issue Jul 14, 2021 · 2 comments
Open

remove classes Minilogger and Pipe #6

gogo2464 opened this issue Jul 14, 2021 · 2 comments

Comments

@gogo2464
Copy link
Contributor

Pipe() could be replaced by os.pipe and Minilogger could be repalced by print or another built in function. This code is useless.

@masthoon
Copy link
Owner

I agree that we could replace Pipe object with os.pipe (+set_inheritable for subprocess) if it works.
Regarding Minilogger, I disagree, logging has many more advantages than using print (filtering, line + context info, easy to redirect to socket/file), I don't think we should remove it.

@gogo2464
Copy link
Contributor Author

Then we could use

import logging
logging.info("info")
logging.debug("debug")
logging.error("error")

it is a built in function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants