Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes React Native 0.69.x #374

Open
Nantris opened this issue Aug 19, 2022 · 6 comments
Open

Crashes React Native 0.69.x #374

Nantris opened this issue Aug 19, 2022 · 6 comments

Comments

@Nantris
Copy link

Nantris commented Aug 19, 2022

The line that fails is buttonTextStyle: Text.propTypes.style,

@mastermoo, would you be open to accepting a PR for this issue? I would make one, but I don't want to bother if there's no chance of acceptance.

@LucasPMM
Copy link

LucasPMM commented Sep 5, 2022

It's not working on expo v46, I think it's related.

@Nantris
Copy link
Author

Nantris commented Sep 5, 2022

@LucasPMM you can use patch-package to disable that line. It's not Expo, but rather the new version of React Native: facebook/react-native#33557

I found it basically impossible to upgrade without relying on patch-package.

I'd still be open to submitting a PR to fix this, but if @mastermoo isn't around to accept it, then meh.

@approached
Copy link

I have the same error with 70.x version. You can solve the error with only one line. However, it does not bring to make a new pull request. Because the maintainer does not respond anyway.

It is time to make a new package with the whole pull request!

Does anyone want to participate in the team on the package?

@Nantris
Copy link
Author

Nantris commented Oct 29, 2022

@approached that's probably a good idea since componentWillReceiveProps is used in the code, which is long deprecated. Replacing that single function, plus fixing this issue and #339 would bring everything up to speed I think.

@Shin1122
Copy link

Shin1122 commented Nov 4, 2022

same problem on 70.x, waiting for the solution ~

@Nantris
Copy link
Author

Nantris commented Nov 4, 2022

@Shin1122 this repo is unmaintained. Use patch-package to comment out lines that contain references to Text.propTypes or ViewPropTypes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants