Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VESPA_target_* global attribute #57

Open
BaptisteCecconi opened this issue Mar 31, 2023 · 1 comment
Open

Fix VESPA_target_* global attribute #57

BaptisteCecconi opened this issue Mar 31, 2023 · 1 comment
Assignees

Comments

@BaptisteCecconi
Copy link
Collaborator

Currently, the VESPA_target_name and VESPA_target_class attributes are a text string, with # separator.

Example:

VESPA_target_name = "Jupiter#Io"
VESPA_target_class = "planet#satellite"

We should transform this into a list of terms:

VESPA_target_name = ["Jupiter", "Io"]
VESPA_target_class = ["planet", "satellite"]
@BaptisteCecconi
Copy link
Collaborator Author

The current implementation also adds an extra # at the end of VESPA_target_name when there should be only Jupiter (and then satellite should not be in target class either):

VESPA_target_name = "Jupiter#"
VESPA_target_class = "planet#satellite"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants