Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider checking a template-derived draft for substantial diff, to prevent PEBKAC-00 #372

Open
LPardue opened this issue Mar 8, 2023 · 2 comments

Comments

@LPardue
Copy link
Contributor

LPardue commented Mar 8, 2023

Due to operator error, its possible to submit drafts before they are really ready. Solving that in the general case is a hard problem. However, its probably a lot easier to solve the case where someone checks out the template, does a load of work, and then in a rush tags git in a way that would produce a pretty embarrassing 00 draft*.

  • not on embarassing but also noisy and distracting for the datatracker
@martinthomson
Copy link
Owner

Best. Draft. Ever.

Frankly, I don’t really know what you would test for to avoid this problem. All the usual indicators of templateness are gone.

Maybe a datatracker change to show draft previews would help. Right now you can submit the draft without ever seeing it. WDYT?

@rjsparks
Copy link

@LPardue - would having a preview have caused you to pause in this particular case?

I'm not sure the template-like shape has been obfuscated so much that a diff warning couldn't be raised, Something like "This has only 3 sentences that are not boilerplate" (which you could do off the text version) raised as a warning might catch someone's eye more than a preview full of boilerplate would...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants