Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow vector ids in calls #13

Open
martigso opened this issue Apr 17, 2024 · 0 comments
Open

Allow vector ids in calls #13

martigso opened this issue Apr 17, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@martigso
Copy link
Owner

One recurring issue for users is the (slightly) more complex iterative reliant nature of the package. Currently, all functions are built in a way that for-loops or apply-family functions can be used to access multiple IDs. For instance, to download the MPs "JGS", "TSG", and "MOM", we currently need to iterate over these:

mps <- list()

for(i in c("JGS", "TSG", "MOM")) {
  mps[[i]] <- get_mp(i, good_manners = 2)
}

A more smooth user experience would be to allow the users to just supply the vector of IDs directly:

mps <- get_mp(c("JGS", "TSG", "MOM"), good_manners = 2)

In order to not break backwards-compatability, we could implement a vector length check, for instance.

@martigso martigso added the enhancement New feature or request label Apr 17, 2024
@martigso martigso self-assigned this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant