Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong implementation of countInStore-Service-Method? #171

Open
DarkTank2 opened this issue Apr 16, 2024 · 0 comments
Open

Wrong implementation of countInStore-Service-Method? #171

DarkTank2 opened this issue Apr 16, 2024 · 0 comments

Comments

@DarkTank2
Copy link

The type signature of the countInStore-service-method is

countInStore(params?: MaybeRef<SvcParams<Svc>>): Paginated<never>

src/create-pinia-service.ts line 179

Yet the implementation returns just a number, which equals to the total amount of records found.
src/stores/local-queries.ts line 140
See especially line 148 where only the total of the result is returned instead of the paginated result.

So I think the signature schould either be changed to

countInStore(params?: MaybeRef<SvcParams<Svc>>): ComputedRef<number>

or the implementation of the method should be adapted so that it returns the paginated result and fits with the definition of the count-service-method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant