Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a seperate Settlement Template Configuration class #1290

Open
bevans2000 opened this issue Apr 27, 2024 · 0 comments
Open

Create a seperate Settlement Template Configuration class #1290

bevans2000 opened this issue Apr 27, 2024 · 0 comments
Milestone

Comments

@bevans2000
Copy link
Member

Is your feature request related to a problem? Please describe.
SettlementConfig class play 3 roles:

  1. Global configurations for Settlement, e.g. Shifts, Group Activities
  2. Repository for SettlementTemplates using the existing UserConfiguration pattern
  3. Holds FunctionSpec extra properties, e.g. ScienceLevel for a RESEARCH function.

This make the class very big and has a mixture of logic. Plus SettlementTemplates are transient and only needed when creating Settlements.

Describe the goal(s) you have in mind
Separate the Settlement template logic out into a new class called SettlementTemplateConfg. This will focus solely on loading and saving Settlement Templates.
In addition it will ensure that any FunctionSpec properties are solely within the template and not in the main SettlementConfiguration. The existing FunctionSpec will be subclassed for the Function that need extra configuration properties.

@bevans2000 bevans2000 added this to the 3.9.0 milestone Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant