Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Rating Score to interface #1289

Open
bevans2000 opened this issue Apr 27, 2024 · 0 comments
Open

Convert Rating Score to interface #1289

bevans2000 opened this issue Apr 27, 2024 · 0 comments
Assignees
@bevans2000
Labels
design change A change to the code to improve performance or reusability
Milestone
3.9.0

Comments

@bevans2000
Copy link
Member

bevans2000 commented Apr 27, 2024 •
edited

The RatingScore instances are shared between Settlement tasks and Worker tasks.

To prevent the shared instances being modified outside of scope the RatingScore should become a immutable interface. A new implementation class will be created that allows score to be constructed.
In addition a new RatingScoreFormatter should be created to centralise text & HTML renderings of a RatingScore.

This is a shortcoming of the original design of this pattern.
@bevans2000 bevans2000 self-assigned this Apr 27, 2024
@bevans2000 bevans2000 added the design change A change to the code to improve performance or reusability label Apr 27, 2024
@bevans2000 bevans2000 added this to the 3.9.0 milestone Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bevans2000 bevans2000

Labels
design change A change to the code to improve performance or reusability
Projects
Use Rating instead of simple score
Status: No status
Milestone
3.9.0
Development

No branches or pull requests
1 participant
@bevans2000