Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Person Favourites & Preference class to the generic ParameterManager #1213

Open
bevans2000 opened this issue Jan 7, 2024 · 3 comments
Labels
design change A change to the code to improve performance or reusability
Milestone

Comments

@bevans2000
Copy link
Member

Is your feature request related to a problem? Please describe.
End users cannot change the favourites or task preferences of a Person. Using the ParameterManager class will allow the user control.

Describe the rationale
Use the 2 classes and replace them with an instance of a ParameterManager.
The logic to set-up the initial favourites and preferences will be moved to a new dedicated creator class.
This would allow the generic Preferences panel to be available to the end user to be editable.

@bevans2000 bevans2000 added the design change A change to the code to improve performance or reusability label Jan 7, 2024
@mokun
Copy link
Member

mokun commented Jan 7, 2024

I can see in Settlement Unit Window the Preferences tab has new params to play with as follows :

image

Will you somehow be extending some of the preferences to settlers :

image

As you know, currently, the preference scores of a person on each task are fixed and can't be changed.

@bevans2000
Copy link
Member Author

Exactly the goal of this change. The panel in the screenshot is fully generic so now I can use it in Person as well to control Tasks if we use the Parameter Manager approach.
Also we can further expand it go control Simulation level parameters that are currently fixed in the config files. The latter now become the defaults.
The panel above is a lot more clever handling different types and only adding values that are not in the existing list.

@bevans2000
Copy link
Member Author

I also want yo use this pattern fir #1189
The number of active EVA can be controlled by a parameter that is initially calculated according to the number of airlock

@bevans2000 bevans2000 added this to the 3.9.0 milestone Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design change A change to the code to improve performance or reusability
Projects
None yet
Development

No branches or pull requests

2 participants