Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building's North-to-South alignment was never defined #1188

Open
mokun opened this issue Dec 30, 2023 · 0 comments
Open

Building's North-to-South alignment was never defined #1188

mokun opened this issue Dec 30, 2023 · 0 comments
Assignees

Comments

@mokun
Copy link
Member

mokun commented Dec 30, 2023

Is your feature request related to a problem? Please describe.

  • It's unclear if what width and length mean for each building in buildings.xml.
  • One has to look at the svg image to figure out the North-to-South alignment of the width and length of a building.

Describe the rationale

  • Provide explicit definition on whether the width or length of a building is N-to-S aligned.

Describe the goal(s) you have in mind

  • Explicitly define the N-to-S alignment for each building.

Describe the solution you desire to see

  • Add an attribute for each building in buildings.xml to explicitly define the
    N-to-S alignment.

Screenshots

  • Server Farm's svg image is oriented as follows :
  • width is 9 m
  • length is 7 m
  • It's short edge (aka the length) is N-to-S aligned.
    image
	<building type="Server Farm" width="9.0" length="7.0" base-level="0"
			wear-lifetime="3340000" maintenance-time="150" room-temperature="18" base-mass="4000"
			category="LABORATORY">
		<description>
			The Server Farm is a computer facility providing mainframe resources and networking
			nodes for colony-width computing needs.
		</description>
  • Command and Control's svg image is oriented as follows:
  • width is 7 m
  • length is 9 m
  • It's long edge (aka the length) is N-to-S aligned.
    image
      <building type="Command and Control" width="7.0" length="9.0" base-level="0"
      		wear-lifetime="3340000" maintenance-time="150" room-temperature="22.5" base-mass="4000">
      	<description>
      		The Command and Control is a communication facility with networking
      		capability for high speed communications and colony-width connectivity.
      		It also coordinates EVA operations.
      	</description>

**Specifications**
- post 3.7.0 build 9160

**Additional context**
- This would help defining the orientation of the construction site during Construction Mission as well as the incoming building from a resupply mission.
@mokun mokun changed the title Building facing and North-to-South alignment a Building's North-to-South alignment was never defined Dec 30, 2023
@mokun mokun changed the title a Building's North-to-South alignment was never defined Building's North-to-South alignment was never defined Jan 3, 2024
mokun added a commit that referenced this issue Jan 8, 2024
1.7.2024

- new: add north-south-alignment attribute in each building
- change: revise BuildingConfig and BuildingSpec to be aware of
          alignment param
- change: adjust activity spots in Medical Hab

Note: still need more work in how it impacts building rotation and
      facing

Relates to #1188
@mokun mokun self-assigned this Jan 9, 2024
mokun added a commit that referenced this issue Jan 10, 2024
1.9.2024

- new: add 'connector' and 'standalone' element
- change: revise SettlementConfig to process the following 3 lists:
          - building
		  - connector
		  - standalone
- change: test it on settlement_phase_0-ae.xml
- change: replace with HashSet and ArrayList in some methods

Note: will continue to work on simplifying params in settlement
templates such as removing the need for xloc and yloc

Relates to #1188
mokun added a commit that referenced this issue Jan 20, 2024
1.20.2024

- new: add north-south-alignment attribute in foundation, frame and
       building elements in construction.xml
- change: revise ConstructionConfig and ConstructionStageInfo to be
		  aware of alignment param

Note: still need to iron out how it impacts rotation and facing
during construction

Relates to #1188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant