Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand the use of ActivitySpots #1180

Open
bevans2000 opened this issue Dec 22, 2023 · 3 comments
Open

Expand the use of ActivitySpots #1180

bevans2000 opened this issue Dec 22, 2023 · 3 comments
Labels
design change A change to the code to improve performance or reusability improvement
Milestone
3.9.0

Comments

@bevans2000
Copy link
Member

Is your feature request related to a problem? Please describe.
Expand the use of ActivitySpots for other position based data in the building configurations. Also move the Function specific data out of BuildingConfig class into the FunctionSpec. Make the Building Config class generic to make adding new Functions easier.

Describe the rationale
Some Function implementations have to find the parent building spec to construct themselves. This defeats the purpose of the FunctionSpec and also makes unit test harder to write needing more data to be prepared.
@bevans2000 bevans2000 added improvement design change A change to the code to improve performance or reusability labels Dec 22, 2023
mokun added a commit that referenced this issue Dec 23, 2023
@mokun
Rework activity spots and replace buildings
e870e3e 
12.22.2023

- change: replace "Inflatable Greenhouse" with "Fish Farm" or
          "Algae Pond" in a few templates
- change: rework locations of activity spots in "Fish Farm" and
          "Algae Pond"
- fix: reduce pop from 8 to 7 in phase 2 KR template "Residential Hab
- fix: add the 5th bed in "Residential Hab"
In settlement_phase_2-cn.xml,
- change: replace "Machinery Hab" with "Lander Hab"
- change: replace "Inflatable Greenhouse" with "Algae Pond"

Relates to #1166, #1143, #1180
@mokun
Copy link
Member

mokun commented Dec 23, 2023 •
edited

In terms of improving the aesthetic of the activity spot layers, can we do the following 3 things to reduce the overlapping of labels ?

  1. Reduce font size
  2. Use one or two letter acronym for each function type
  3. Reduce the wide gap between the spot and the label

@mokun
Copy link
Member

mokun commented Dec 25, 2023

Expand the use of ActivitySpots for other position based data in the building configurations.

Any examples ?

Also move the Function specific data out of BuildingConfig class into the FunctionSpec.

Sure !

@bevans2000
Copy link
Member Author

Medical beds is one.
Happy Christmas as well

@bevans2000 bevans2000 added this to the 3.9.0 milestone Jan 14, 2024
@bevans2000 bevans2000 mentioned this issue Jan 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design change A change to the code to improve performance or reusability improvement
Projects
None yet
Milestone
3.9.0
Development

No branches or pull requests
2 participants
@mokun @bevans2000