Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track the age of each fish #1169

Open
mokun opened this issue Dec 8, 2023 · 5 comments
Open

Track the age of each fish #1169

mokun opened this issue Dec 8, 2023 · 5 comments

Comments

@mokun
Copy link
Member

mokun commented Dec 8, 2023

Is your feature request related to a problem? Please describe.

  • Currently, the age of each fish in Fishery is not specified.
  • growPerFrame() is called once in each frame, regardless the length of time of a frame. This leads to unpredictable outcome of the size of a fish.

Describe the rationale

  • Adding the age param will enable better lifecycle modeling

Describe the goal(s) you have in mind

  • Further Implement the growth of a fish
  • Add age param in Organism

Describe the solution you desire to see

  • growPerFrame() will have a new param that will increment the age

Specifications

  • pre 3.7.0 build 9058

Additional context

  • Tracking the passage of time of a living organism is crucial when we start modeling the growth of Bee in settlements near future
mokun added a commit that referenced this issue Dec 8, 2023
12.07.2023

- change: reduce worktime in Fishery
- change: reduce weed demand in TendFishTankMeta
- change: vary fresh water to be added in AlgaeFarming
- change: add showing # of weed and total fish weight in
          BuildingPanelFishery
- change: call Animal's growPerFrame() with param time, instead of
		  calling Organism's growPerFrame() without param

Relates to #320, #986, #1169
@mokun
Copy link
Member Author

mokun commented Dec 8, 2023

@bevans2000

It turns out Animal's growPerFrame() already have the time param.

Strangely, Plant doesn't have that ability to sense the passage of time. So weeds in the fish tank are timeless.

I have in mind for modeling trees as well.

Crop seems self-limiting and already is very complicated.

May be in future we could work out the inheritance relationship among Crop and Plant and possibly simplify the code.

@bevans2000
Copy link
Member

I seriously think that modelling individual fish would be a lot of processing for little gain

@mokun
Copy link
Member Author

mokun commented Dec 8, 2023

I seriously think that modelling individual fish would be a lot of processing for little gain

it's already in the code that it tracks the age in Animal class, without me adding it.

Is it a good idea to grow bee yet in a settlement ?

@bevans2000
Copy link
Member

Yes i don't think we use the Animal class anywhere. The Fishery just tracks the total number of Fish.

@mokun
Copy link
Member Author

mokun commented Dec 9, 2023

Yes i don't think we use the Animal class anywhere. The Fishery just tracks the total number of Fish.

Fishery already tracked the size or weight of each fish as an object.

Each weed is an object as well.

We may or may not need that detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants