Null Shipment when negotiating trade in CommerceUtil #1118
Comments
|
@bevans2000 EDIT :
Q: Why aren't they doing the tasks are they supposed to be doing ? |
|
Finally, I've fixed the Settlement Map Tool to display trader Lars and others from another settlement. The two trading rovers from another settlement can now be seen :
|
11.02.2023
- fix: rework drawVehicles() in VehicleMapLayer to display all
vehicles (including trading vehicles) in a settlement
coordinate
- fix: rework drawPeople() in PersonMapLayer to display all
people (including trading guests) in a settlement
coordinate
- change: revise isVehicleLoading() in VehicleMapLayer
- fix: correct drawPersonLabels() and drawVehicleLabels()
in LabelMapLayer
- change: rename and relocate getAssociatedRobotsInSettlementVicinity)
to CollectionUtils
- change: revise selectVehicleAt() and selectVehicleAsObstacle() in
SettlemenMapPanel to use CollectionUtils's
getVehiclesInSettlementVicinity()
Address #1118
Reverse some code change done in #1057
|
Nice one |
|
Can we create a test scenario in which two settlements are very close to each other and auto-launch a trading mission to see what else is still not well considered once the foreign settlers arrive at a destination settlement ? The guest beds will need to be ready for them to rest. They should be on the road after recuperating. What else are they allowed to do there ? |
|
Q1: Can we at least test to see if the Sleep task works now in foreign settlement ? Q2: What does it take to prevent them from performing other non-essential tasks (such as digging regolith) in a foreign settlement ? |
|
I want to solve the problem of executing Tasks in a Unit test. Sleep would be a good one lets use this issue to create that. Stopping the complex Tasks when away should work already. Settlement tasks can be filtered to only Workers in their home Settlement. |
That's great ! But what tasks can still be performed in foreign settlement ? Can we instead have an UI for players or commanders to choose what tasks are allowed or disallowed ? |
Let's pay attention to what tasks will be allowed to performed in a foreign settlement. What "rules" should they follow ? |
Describe the bug
Expected and unexpected behavior
Discuss any potential problems you have and have not ruled out
Java classes involved
CommerceUtil,NegotiateTradeScreenshots
Both rovers drove 964 km from Heritage to Dream City.
Event though they both departed on sol 5 and arrived on sol 6, their start time and arrival time were different.
Realistically speaking, the path between the two settlements shouldn't be a straight shot but a curve on a sphere.
None of the 6 settlers in Dream City are aware of the arrival of the 2 trading missions.
They all stay indoors and are NOT helping to unload cargoes
The 2 sleepy head settlers on Rover Ridge Runner from Heritage are still in the vehicle.
The 2 sleepy head settlers on Rover Solitude from Heritage are still in the vehicle.
These 2 rovers are not being displayed on the Settlement Map of Dream City, since Settlement's getParkedVehicles() includes only vehicles from the ownedVehicles set.
Can't find the 2 rovers from Heritage :
Nothing has been unloaded yet :
Both settlers are healthy and have little fatigue. Why are they sleeping and not unloading cargo ?
Why are the sleeping probability score 1000 for both of them ?
Why are the base score so high (at 6000) ?
It's totally wrong to say that these 4 individuals are still on EVA Airlock 1 or Residential Quarters 1 in Heritage.
We should add back the Settlement column to ascertain what base the settlers are in.
Other than the trading mission., we should leave provision for them go to other settlement in other future missions such as Diplomatic Exchange missions, etc.
Stacktrace
Specifications
Additional context
The text was updated successfully, but these errors were encountered: