Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix softbreak rendering within mixed namespace #292

Open
yhatt opened this issue May 5, 2021 · 1 comment
Open

Fix softbreak rendering within mixed namespace #292

yhatt opened this issue May 5, 2021 · 1 comment

Comments

@yhatt
Copy link
Member

yhatt commented May 5, 2021

Reported in marp-team/marp#106.

Marp Core will convert line breaks always into <br /> tag for compatibillity with the classic Marp app. However, they may break rendering in the mixed namespace such as <svg> and <math> because <br> is available only in HTML namespace.

There is no problems in both parsers. We may have to consider the current namespace (explicit xmlns attribute and implicit <svg> and <math>) in softbreak token rendering.

@yhatt yhatt transferred this issue from marp-team/marp-core May 5, 2021
@yhatt
Copy link
Member Author

yhatt commented May 5, 2021

Transferred from Marp Core into Marpit. Patching on the level of framework should be better for the other Marpit flavored converters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant