Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable suggestion scrolling without setting a hard limit #714

Open
NIV54 opened this issue Apr 12, 2024 · 1 comment
Open

Enable suggestion scrolling without setting a hard limit #714

NIV54 opened this issue Apr 12, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@NIV54
Copy link

NIV54 commented Apr 12, 2024

What do you want?

An option to scroll choose a default number of history-lines and scroll to previous history-lines instead of circling back to the first one.

Why do you want this?

When using small terminals (for example - embedded terminal in VSCode) the number of history-lines is too small. If I see 5 history-lines, there is no scrolling back to suggestion 6. The only way to go around that is to manually set the number of lines to be something bigger. Let's say for the sake of argument that 20 is a fair number.
Now if a bigger number like 20 is set, when using the same terminal on a bigger screen the history-lines take up the entire screen and you can see the output of the previous command as the command you're typing goes to the top of the screen.

Who else would benefit from this?

Everyone who uses different terminal sizes on the same machine. This is common when opening a stand-alone terminal and a minified terminal in another program (like code editors).

How should it work?

I see two options:

  1. A config that will set the number of lines that are shown in the menu (if possible due to screen size), and the default beyond that would be scrolling to another menu instead of circling back to the start
  2. Same config as above, and an additional config that will set the limitation for the number of total history-lines. For example, menu size is 10 and the total is 50 - so you'll be able to scroll 40 more history-lines past the first 10 before circling back to start.

Given the following situation:
When the appropriate config is set

When I perform the following steps:
When scrolling with the up arrow past the last suggestion shown

Then I expect the following to happen:
I'll see more history-lines

@NIV54 NIV54 added the enhancement New feature or request label Apr 12, 2024
@L0laapk3
Copy link

I think there are actually two separate suggestions or at least two steps to this suggestion:

  1. Split up list-lines: Currently list-lines controls both the maximum number of search results, and the number of lines displayed. It would be very nice to be able to control these two things individually.
  2. The option not to limit the maximum number of search results.

From my perspective, I would love to have 1, while 2 is not such a big deal as a very large limit can just be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants